Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[typescript] Add null to return type of OverridableComponent #35311

Merged
merged 2 commits into from
Dec 12, 2022
Merged

[typescript] Add null to return type of OverridableComponent #35311

merged 2 commits into from
Dec 12, 2022

Conversation

tsollbach
Copy link
Contributor

closes #32420

@mui-bot
Copy link

mui-bot commented Dec 1, 2022 •
edited
Loading

Messages
📖 Netlify deploy preview: https://deploy-preview-35311--material-ui.netlify.app/

No bundle size changes

Generated by 🚫 dangerJS against 96ea00f

@tsollbach tsollbach mentioned this pull request Dec 1, 2022
Closed
2 tasks
@mnajdova mnajdova requested a review from michaldudak December 1, 2022 15:19
@ZeeshanTamboli ZeeshanTamboli changed the title [OverridableComponent]: add null to return type [typescript] Add null to return type of OverridableComponent Dec 3, 2022
michaldudak
michaldudak approved these changes Dec 7, 2022
View reviewed changes
Copy link
Member

@michaldudak michaldudak left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! It's a great first PR in MUI!

HHK1
HHK1 reviewed Dec 9, 2022
View reviewed changes
packages/mui-material/src/OverridableComponent.d.ts Outdated
@@ -20,7 +20,7 @@ export interface OverridableComponent<M extends OverridableTypeMap> {
*/
component: C;
} & OverrideProps<M, C>,
): JSX.Element;
): JSX.Element | null;
(props: DefaultComponentProps<M>): JSX.Element;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this return type should also be JSXElement | null

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Right, I missed it as well

@michaldudak michaldudak merged commit f8e1f6e into mui:master Dec 12, 2022
@tsollbach tsollbach deleted the overridable-component-return-type-fix branch December 12, 2022 15:36
@thomasdax98 thomasdax98 mentioned this pull request Jan 19, 2023
Merged
@LTakhyunKim LTakhyunKim mentioned this pull request Nov 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HHK1 HHK1 HHK1 left review comments

@michaldudak michaldudak michaldudak approved these changes

Assignees
No one assigned
Labels
typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[typescript] Incompatible types between React.forwardRef and OverridableComponent
5 participants
@tsollbach @mui-bot @michaldudak @HHK1 @zannager